server: contain exceptions thrown by user callbacks - #198
Open
physwkim wants to merge 1 commit into
Open
Conversation
A throw from onSubscribe(), onStart(), onCancel() or onClose() reached ConnBase::bevRead(), which resets the circuit and so drops every other channel on it. MonitorSetupOp::connect() throws for a pvRequest which selects no fields, so a Source not repeating SharedPV's own try/catch lets any client do that. Escaping ServerOp::cleanup() also leaves the op short of Dead, so ~ServerOp() asserts.
physwkim
force-pushed
the
fix/monitor-setup-exception
branch
from
July 27, 2026 09:09
d3dcc1f to
bd2243d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MonitorSetupOp::connect()throws for a pvRequest which selects no fields, and onlySharedPVguards it (connectSub()), so withSingleSource,GroupSource, or any Source written from the docs, a client sendingfield(nosuchfield)reset the whole TCP circuit and dropped its other channels. On the DESTROY_REQUEST path the throw also escapesServerOp::cleanup()beforestate=Dead, so~ServerOp()trips its assert. The newtestmoncases fail without this change; the first of them needs no throwing user code at all.Callbacks reached through
acceptor_loop.dispatch()(onLowMark(),onHighMark(), the dispatched closer) are already covered byevbase::Pvt::doWork()and are untouched; theCMD_CANCEL_REQUESTguard has no test because pvxs' own client never sends that message.