Remove failing assert #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of setuptools 77.0.3, this assert is no longer passing. This means projects that require this for building cannot build, and projects that use it at runtime (e.g. cothread's catools) cannot run. It should be noted that this passes under setuptools 77.0.1, so there is apparently a breaking change in a minor release.
coretl
approved these changes
Mar 21, 2025
abbiemery
approved these changes
Mar 21, 2025
abbiemery
left a comment
abbiemery
left a comment
There was a problem hiding this comment.
I have checked this changes against blueapi and ophyd-async and this does remove the problem and allow us to run tests again. This is clearly symptomatic of a different issue and I worry about the implications of just removing this line, but when i run all the test suites including the system tests they all pass again. So it is probably safe enough for now.
Member
I originally put this assertion in to detect unexpected monkey-patching without a specific misbehavior in mind. A warning might have been better.
Probably the best we can hope for at present... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of setuptools 77.0.3, this assert is no longer passing. This means projects that require this for building cannot build, and projects that use it at runtime (e.g. cothread's catools) cannot run.
It should be noted that this passes under setuptools 77.0.1, so there is apparently a breaking change in a minor release.
I'm creating this PR as this is a major blocker for the Bluesky projects, in the hopes we can quickly make a minor patch release. I'm still investigating the underlying cause of this new failure and may have more to say in the future.