-
Notifications
You must be signed in to change notification settings - Fork 37
Create StateEnum PVs to convert from longout to mbbo #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create StateEnum PVs to convert from longout to mbbo #86
Conversation
c50aae8 to
5866444
Compare
Create mbbo SR_X_StateEnum records to convert from longout SR_X_State, to display method names instead of raw integer values. The State PV tracks which save method is currently active for each save set. State values: - 0: None - 1: Periodic - 2: Triggered - 4: Timer - 12: Monitored (Timer + Change combined) - 16: Manual Value 8 (Change) is not included as it is an intermediate state that only triggers saves when combined with Timer to form Monitored. Non-listed values _can_ occur but do not have enumerations; each loop of plist processing will first perform saves and then immediately clear the bits.
5866444 to
b3a280a
Compare
|
After a fair amount of private discussion about the purpose of this change and the best way to convey the information that it is trying to convey, I think I am happy to accept this change. On the one hand, it is "technically wrong" in that it doesn't cover all possible states. On the other hand, what it does seem to cover is the most likely ways in a way that provides useful feedback to anyone attempting to access information about the autosave state. I'm happy to approve this, but it might be nice for some sanity feedback from anyone else (e.g. @anjohnson @keenanlang ): do at any sites combine the various save methods on the same file? |
I don't believe that any of the beamline IOC's combine different save methods in a singular file. At least not anything even remotely recent. |
We already have this change in place for us. @simon-ess suggested I submit it also here - I guess to assist users with deobfuscating the record values. So consider this a contribution to assist documentation.
I had no plans to do so. We do not use these screens. I am not sure if I could make that contribution as I never have worked with MEDM displays. |
|
I think that given @keenanlang 's comment, I am happy to call this good and merge it in. |


Uh oh!
There was an error while loading. Please reload this page.