Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions .github/workflows/ci-scripts-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,68 +39,69 @@ jobs:
fail-fast: false
matrix:
include:
- os: ubuntu-20.04
- os: ubuntu-22.04
cmp: gcc
configuration: default
base: "7.0"
wine: "64"

- os: ubuntu-20.04
- os: ubuntu-22.04
cmp: gcc
configuration: static
base: "7.0"

- os: ubuntu-20.04
- os: ubuntu-22.04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to switch to ubuntu-latest to avoid some future churn?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For stability, pick a specific version. Perhaps ubuntu-24.04? Then, a few years to revisit the decision.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to switch to ubuntu-latest to avoid some future churn?

Done.

cmp: gcc
configuration: default
base: "3.15"

- os: ubuntu-20.04
- os: ubuntu-22.04
cmp: gcc
configuration: default
base: "3.14"

- os: ubuntu-20.04
- os: ubuntu-22.04
cmp: gcc
configuration: static
base: "7.0"
extra: "CMD_CXXFLAGS=-std=c++11"

- os: ubuntu-20.04
- os: ubuntu-22.04
cmp: clang
configuration: default
base: "7.0"
extra: "CMD_CXXFLAGS=-std=c++11"

- os: ubuntu-20.04
cmp: gcc
configuration: default
base: "7.0"
rtems: "4.10"
# It requires more debugging:
# - os: ubuntu-22.04
# cmp: gcc
# configuration: default
# base: "7.0"
# rtems: "4.10"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any opinion on RTEMS is outside my competence. I suggest @mdavidsaver reviews this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirk-zimoch This is something I am not sure about because rtems: "4.9" works without problems. It would be good if the author of rtems: "4.10" does the review. I commented it out with a note. This was already not working for a long time regardless of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea for handling that is to create a GitHub issue about rtems: "4.10" and merge this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current state of the epics-base GHA jobs is that the RTEMS 4.10 build does not run tests. There are also RTEMS 5.1 jobs.

https://github.com/epics-base/epics-base/blob/7.0/.github/workflows/ci-scripts-build.yml#L111-L149

- os: ubuntu-20.04
- os: ubuntu-22.04
cmp: gcc
configuration: default
base: "7.0"
rtems: "4.9"

- os: ubuntu-20.04
cmp: gcc-8
utoolchain: "8"
- os: ubuntu-22.04
cmp: gcc-9
utoolchain: "9"
configuration: default
base: "7.0"

- os: ubuntu-20.04
- os: ubuntu-22.04
cmp: clang
configuration: default
base: "7.0"

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
submodules: true
- name: Cache Dependencies
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: ~/.cache
key: ${{ matrix.base }}/${{ matrix.os }}/${{ matrix.cmp }}/${{ matrix.configuration }}/${{ matrix.wine }}${{ matrix.rtems }}/${{ matrix.extra }}
Expand Down