motorRecord: prevent endless loop VAL-HOMF-VAL #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following lead to an endless loop: - move the motor by writing to the .VAL field - while moving, home the motor using the HOMF field - while still homing, write a different value to the VAL field. The problem is that for "pmr->val != pmr->lval" the motorRecord is send into do_work() and a new HOME is started. Solution: Reset the HOMF and HOMR buttons.
Member
|
@tboegi, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following lead to an endless loop:
The problem is that for "pmr->val != pmr->lval" the motorRecord is send into do_work() and a new HOME is started.
Solution:
Reset the HOMF and HOMR buttons.