fix: prevent user avatar from shrinking #1035
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user avatar element on the
/users/:username/notespage shrinks, resulting in a broken UI:This is even more apparent with a placeholder avatar:
This happens because the
Linkparent hasdisplay: flexand the text content (the user name) takes priority when it grows, shrinking the image.Now, traditionally, you fix this by setting
flex-shrink: 0on the element whose dimensions you wish to preserve. Alas, the component tree of theImgcomponent doesn't make that fix possible as the classes you provide to the component end up on the<img />element and not the parent<picture />element, which is the child of the flex container:As such, I'm proposing the next best thing, which is to fallback to the next responsive state of this element sooner:
This makes the avatar/username wrap sooner, preventing the shrunk avatar issue.
Test Plan
Checklist
Screenshots