-
Notifications
You must be signed in to change notification settings - Fork 460
build(deps): remove chalk and use styleText instead
#798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): remove chalk and use styleText instead
#798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super!
|
styleText doesn't land until Node 22 (node 21.7 technically) which won't be LTS until October, so I don't think we can merge this until then based on this decision doc https://github.com/epicweb-dev/epic-stack/blob/main/docs/decisions/021-node-version.md |
I am so used to using it that I didn't realize it is still in I will try to keep this PR up-to-date until it is stablized. |
|
Another point: this does not actually remove |
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
Signed-off-by: Hunar Roop Kahlon <[email protected]>
353f1d2 to
181f7e2
Compare
What do you think about updating the requirement to Node I'm used to work with |
|
Why don't node managers reference the engines config in the package.json? I'd really rather avoid adding an extra file to the root just for the node version. |
|
I'm going to close this for now. We can revisit when Node 22 is our base. |
|
Now we're running on node version 22. So we can look into doing this. There have been a number of changes to these different files. So if you would like to update your pull request with what is latest on main and get everything ready to go then that would be really appreciated. And then we can get this merged in. Thanks. |
|
I can look into this in a few days... |
|
superceded by #928 |
chalkwithstyleTextchalkTest Plan
No tests or docs need changing
Screenshots
No change that requires diff of screenshots
closes: #792