Skip to content

change sentry import to correct package #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025
Merged

change sentry import to correct package #903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
620fb55
change sentry import to correct package
nichtsam Jan 17, 2025
46a728a
modify docs to reflect current sentry situation
nichtsam Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions docs/monitoring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ env var during runtime:
fly secrets set SENTRY_DSN=<your_dsn>
```

See the guide for the remix
[here](https://docs.sentry.io/platforms/javascript/guides/remix/). Run the
installation wizard but note that some of the steps included already exist in
this codebase so be sure to remove any duplication.
See the guides for React Router v7
[here(library)](https://docs.sentry.io/platforms/javascript/guides/react/features/react-router/v7/)
and
[here(framwork)](https://docs.sentry.io/platforms/javascript/guides/react-router/).
Note that the dedicated SDK for React Router is under development and features
are lacking.

To generate the auth token, click
[this](https://sentry.io/orgredirect/settings/:orgslug/developer-settings/new-internal/)
Expand Down
6 changes: 3 additions & 3 deletions server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import crypto from 'node:crypto'
import { createRequestHandler } from '@react-router/express'
import * as Sentry from '@sentry/react'
import * as Sentry from '@sentry/node'
import { ip as ipAddress } from 'address'
import chalk from 'chalk'
import closeWithGrace from 'close-with-grace'
Expand Down Expand Up @@ -144,7 +144,7 @@ const maxMultiple =
!IS_PROD || process.env.PLAYWRIGHT_TEST_BASE_URL ? 10_000 : 1
const rateLimitDefault = {
windowMs: 60 * 1000,
limit: 1000 * maxMultiple,
limit: 1000 * maxMultiple,
standardHeaders: true,
legacyHeaders: false,
validate: { trustProxy: false },
Expand All @@ -166,7 +166,7 @@ const strongestRateLimit = rateLimit({
const strongRateLimit = rateLimit({
...rateLimitDefault,
windowMs: 60 * 1000,
limit: 100 * maxMultiple,
limit: 100 * maxMultiple,
})

const generalRateLimit = rateLimit(rateLimitDefault)
Expand Down
7 changes: 3 additions & 4 deletions server/utils/monitoring.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { prismaIntegration, httpIntegration } from '@sentry/node'
import * as Sentry from '@sentry/node'
import { nodeProfilingIntegration } from '@sentry/profiling-node'
import * as Sentry from '@sentry/react'

export function init() {
Sentry.init({
Expand All @@ -18,8 +17,8 @@ export function init() {
/\/site\.webmanifest/,
],
integrations: [
prismaIntegration(),
httpIntegration(),
Sentry.prismaIntegration(),
Sentry.httpIntegration(),
nodeProfilingIntegration(),
],
tracesSampler(samplingContext) {
Expand Down