Skip to content

sentry don't capture response #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

sentry don't capture response #917

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5965d5d
sentry don't capture response
nichtsam Feb 3, 2025
f5accec
Update app/components/error-boundary.tsx
kentcdodds Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/components/error-boundary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,23 @@ export function GeneralErrorBoundary({
}) {
const error = useRouteError()
const params = useParams()
const isResponse = isRouteErrorResponse(error)

if (typeof document !== 'undefined') {
console.error(error)
}

useEffect(() => {
if (isResponse) {
return
}

captureException(error)
}, [error])
}, [error, isResponse])

return (
<div className="container flex items-center justify-center p-20 text-h2">
{isRouteErrorResponse(error)
{isResponse
? (statusHandlers?.[error.status] ?? defaultStatusHandler)({
error,
params,
Expand Down