Skip to content

improve playwright tests #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025
Merged

improve playwright tests #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37d4638
remove expects for pending state
nichtsam Feb 18, 2025
d7820bb
limit github user mocks username length
nichtsam Feb 18, 2025
a0ea160
ensure js is loaded before testing components that depend on it
nichtsam Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions tests/e2e/onboarding.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ test('onboarding with link', async ({ page, getOnboardingData }) => {
await emailTextbox.fill(onboardingData.email)

await page.getByRole('button', { name: /submit/i }).click()
await expect(
page.getByRole('button', { name: /submit/i, disabled: true }),
).toBeVisible()
await expect(page.getByText(/check your email/i)).toBeVisible()

const email = await readEmail(onboardingData.email)
Expand Down Expand Up @@ -92,6 +89,8 @@ test('onboarding with link', async ({ page, getOnboardingData }) => {

await page.getByLabel(/^confirm password/i).fill(onboardingData.password)

await page.waitForLoadState('networkidle') // ensure js is fully loaded.

await page.getByLabel(/terms/i).check()

await page.getByLabel(/remember me/i).check()
Expand Down Expand Up @@ -120,9 +119,6 @@ test('onboarding with a short code', async ({ page, getOnboardingData }) => {
await emailTextbox.fill(onboardingData.email)

await page.getByRole('button', { name: /submit/i }).click()
await expect(
page.getByRole('button', { name: /submit/i, disabled: true }),
).toBeVisible()
await expect(page.getByText(/check your email/i)).toBeVisible()

const email = await readEmail(onboardingData.email)
Expand Down Expand Up @@ -173,6 +169,7 @@ test('completes onboarding after GitHub OAuth given valid user details', async (
name: /create an account/i,
})

await page.waitForLoadState('networkidle') // ensure js is fully loaded.
await page
.getByLabel(/do you agree to our terms of service and privacy policy/i)
.check()
Expand Down Expand Up @@ -313,6 +310,8 @@ test('shows help texts on entering invalid details on onboarding page after GitH
await expect(page).toHaveURL(/\/onboarding\/github/)

// we are all set up and ...

await page.waitForLoadState('networkidle') // ensure js is fully loaded.
await page
.getByLabel(/do you agree to our terms of service and privacy policy/i)
.check()
Expand Down Expand Up @@ -350,9 +349,6 @@ test('reset password with a link', async ({ page, insertNewUser }) => {
).toBeVisible()
await page.getByRole('textbox', { name: /username/i }).fill(user.username)
await page.getByRole('button', { name: /recover password/i }).click()
await expect(
page.getByRole('button', { name: /recover password/i, disabled: true }),
).toBeVisible()
await expect(page.getByText(/check your email/i)).toBeVisible()

const email = await readEmail(user.email)
Expand All @@ -377,9 +373,6 @@ test('reset password with a link', async ({ page, insertNewUser }) => {
await page.getByLabel(/^confirm password$/i).fill(newPassword)

await page.getByRole('button', { name: /reset password/i }).click()
await expect(
page.getByRole('button', { name: /reset password/i, disabled: true }),
).toBeVisible()

await expect(page).toHaveURL('/login')
await page.getByRole('textbox', { name: /username/i }).fill(user.username)
Expand Down Expand Up @@ -408,9 +401,6 @@ test('reset password with a short code', async ({ page, insertNewUser }) => {
).toBeVisible()
await page.getByRole('textbox', { name: /username/i }).fill(user.username)
await page.getByRole('button', { name: /recover password/i }).click()
await expect(
page.getByRole('button', { name: /recover password/i, disabled: true }),
).toBeVisible()
await expect(page.getByText(/check your email/i)).toBeVisible()

const email = await readEmail(user.email)
Expand Down
3 changes: 2 additions & 1 deletion tests/mocks/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { fileURLToPath } from 'node:url'
import { faker } from '@faker-js/faker'
import fsExtra from 'fs-extra'
import { HttpResponse, passthrough, http, type HttpHandler } from 'msw'
import { USERNAME_MAX_LENGTH } from '#app/utils/user-validation.ts'

const { json } = HttpResponse

Expand Down Expand Up @@ -54,7 +55,7 @@ function createGitHubUser(code?: string | null) {
code,
accessToken: `${code}_mock_access_token`,
profile: {
login: faker.internet.username(),
login: faker.internet.username().slice(0, USERNAME_MAX_LENGTH),
id: faker.number.int(),
name: faker.person.fullName(),
avatar_url: 'https://github.com/ghost.png',
Expand Down