Migrate from storing images in SQLite to Tigris #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…torage - Migrate environment variables to AWS-style naming - Implement signed request generation for S3 storage - Update storage utility functions to use signed requests - Add new dev script to run without mocks - Update documentation and example environment file
also write decision doc and documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning is all in the decision doc that's in this set of code changes.
Test Plan
I verified that this works in staging as well as local development, even if you don't have the environment variables set. If you have mocking enabled, which is on by default in development, everything works locally with those mocks. Existing tests passes.
Checklist
Screenshots
No visual changes.