Move logo to components folder. #985
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logo component looks out of place in root route, it should rather be in components folder where other pages can also import if required. The PR follows "full stack components" approach. |
|
Thanks, but personally I don't think it's necessary to move it unless you really do need to use this component elsewhere. Thanks anyway! |
|
Edit: Gives more flexibility to user in implementing the Logo and it's use anywhere. For eg. the user can add a "size" prop and use the logo in a form elsewhere. Current implementation assumes that logo shall be used only in root route, which imho is restricting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Logo component to components folder.
Test Plan
Checklist
NA
Screenshots