Skip to content

fix(instructions): react-hooks 02.01 #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2024
Merged

fix(instructions): react-hooks 02.01 #239

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab3e498
fix(instructions): react-hooks 02.01
MikeRatcliffe Oct 12, 2024
461b93c
fix(instructions): Explain that react-hooks 02.01 should be broken
MikeRatcliffe Oct 12, 2024
d05b52d
Apply suggestions from code review
kentcdodds Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions exercises/02.side-effects/01.problem.effects/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ function App() {

// 🐨 add a useEffect(() => {}, []) call here (we'll talk about that empty array later)
// 🐨 in the useEffect callback, subscribe to window's popstate event
// 🦉 if that doesn't make sense to you... don't worry, it's supposed to be broken! We'll fix it next
// 🐨 your event handler should call setQuery to getQueryParam()
// 📜 https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

Expand Down