-
Notifications
You must be signed in to change notification settings - Fork 12
Remove path filters from R-CMD-check and test-coverage #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update render_readme.yml to use app token so PRs created by this workflow trigger CI checks. The default GITHUB_TOKEN doesn't trigger workflows. Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Replace deprecated tibdex/github-app-token@v2 with the official actions/create-github-app-token@v1 action. Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Run these workflows on all PRs so they can be required checks in branch protection. Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughModified three GitHub Actions workflows: removed path-based trigger filters from R-CMD-check.yaml and test-coverage.yaml workflows so they execute on all changes; added GitHub App token generation to render_readme.yml and replaced static GitHub token authentication with the dynamically generated token. Changes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/render_readme.yml (1)
42-42: Consider removing unusedGITHUB_PATenvironment variable.Line 42 sets
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}, but this environment variable does not appear to be used directly in the visible workflow steps. If it was relied upon by dependencies (e.g., R packages), verify it is still needed after switching to the GitHub App token. If unused, consider removing it to reduce confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/R-CMD-check.yaml(0 hunks).github/workflows/render_readme.yml(2 hunks).github/workflows/test-coverage.yaml(0 hunks)
💤 Files with no reviewable changes (2)
- .github/workflows/R-CMD-check.yaml
- .github/workflows/test-coverage.yaml
🧰 Additional context used
🪛 actionlint (1.7.9)
.github/workflows/render_readme.yml
48-48: avoid using deprecated input "app_id" in action "actions/create-github-app-token@v1": 'app_id' is deprecated and will be removed in a future version. Use 'app-id' instead
(action)
49-49: avoid using deprecated input "private_key" in action "actions/create-github-app-token@v1": 'private_key' is deprecated and will be removed in a future version. Use 'private-key' instead
(action)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: ubuntu-latest (devel)
- GitHub Check: ubuntu-latest (release)
- GitHub Check: ubuntu-latest (4.4)
- GitHub Check: macOS-latest (release)
- GitHub Check: ubuntu-latest (oldrel-1)
- GitHub Check: windows-latest (release)
- GitHub Check: pkgdown
🔇 Additional comments (1)
.github/workflows/render_readme.yml (1)
44-109: Ensure GitHub App secrets and permissions are properly configured before merging.The workflow uses a GitHub App token (
APP_IDandAPP_PRIVATE_KEYsecrets) for checkout and pull request creation. Before this workflow can function:
- Create a GitHub App with the
contents: writeandpull-requests: writepermissions- Store the App ID in the
APP_IDrepository secret- Store the private key in the
APP_PRIVATE_KEYrepository secret- Install the GitHub App on this repository
Verify these are configured in repository settings; the workflow will fail at runtime if the secrets are missing or the app permissions are insufficient.
|
What does the GitHub App token add if the CI workflow triggers are removed? |
It's the filters that are removed - in #185 R-CMD-check and test-coverage aren't triggered because of the filters. |
- Use app-id/private-key instead of deprecated app_id/private_key - Remove unused GITHUB_PAT env var (token is passed directly where needed) Co-Authored-By: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Summary
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.