Skip to content

Commit 659aba0

Browse files
committed
Include suggestions and comments from review
1 parent e34c620 commit 659aba0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

git-branching-merging.qmd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@ If necessary and in order to make a 'rebase' rather than a 'squash', the PR hist
8484
## Who merges the pull request?
8585

8686
By convention, the package maintainer is in charge of merging the pull requests.
87-
This is indeed often more convenient as they are aware of other ongoing activities in the package that may impact or be impacted with the incoming changes.
87+
Maintainers are well-placed for this as they are aware of other ongoing activities in the package that may impact or be impacted with the incoming changes.
8888
We also have a guarantee that maintainers have sufficient permissions to merge the pull request, and potentially bypass some checks if necessary, which may not be the case of the contributor.
8989

90-
This recommendation remains valid even if the maintainer if the author of the pull request and they request review from a non-maintainer.
90+
This recommendation remains valid even if the maintainer is the author of the pull request and they request review from a non-maintainer.
9191

92-
As a contributor, if you want to signal your changes are not ready to be merged, you should mark your pull requests as draft.
92+
As a contributor, if you want to signal your changes are not ready to be merged or reviewed, you should mark your pull requests as draft.
9393

9494
In all cases, communication is key.
9595
As a maintainer, if you see a non draft pull request that looks like it might still receive additional changes, please check in with the contributor before proceeding with the merge.

0 commit comments

Comments
 (0)