Open
Conversation
andrei-kh
force-pushed
the
vedana/config-plane
branch
from
cbe4130 to
f169ca2
Compare
elephantum
reviewed
Feb 7, 2026
| @@ -0,0 +1,77 @@ | |||
| """add config plane | |||
Contributor
There was a problem hiding this comment.
Я вот не думаю, что это тут должно быть. Потому что в общем случае БД config-plane - это другая БД, чем БД дева или прода. А тут у нас все миграции относятся к деву или проду.
Скорее всего config-plane мог бы просто лениво инициализировать базу при подключении
Collaborator
Author
There was a problem hiding this comment.
Да, точно в отдельной БД из-за связи дев<->прод, отсюда уберу
Скорее всего config-plane мог бы просто лениво инициализировать базу при подключении
может делать Base.metadata.create_all в create_sql_config_repo?
def create_sql_config_repo(
session_maker: Callable[[], Session],
stage_snapshot_id: int | None = None,
branch: str = "master",
) -> SqlConfigRepo:
with session_maker() as session:
Base.metadata.create_all(bind=session.get_bind())
return SqlConfigRepo(session_maker, stage_snapshot_id, branch=branch)
| if raw is None: | ||
| exists = await asyncio.to_thread( | ||
| self._config_repo.snapshot_exists, str(snapshot_id) | ||
| ) |
Contributor
There was a problem hiding this comment.
Надо config-plane переделать на async что-то я не подумал
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DB_CONN_URIfor ETL,JIMS_DB_CONN_URIfor chat,CONFIG_PLANE_DB_CONN_URIfor config-plane.