show line number when cannot process a transaction#102
Open
splix wants to merge 1 commit intoeprbell:mainfrom
Open
show line number when cannot process a transaction#102splix wants to merge 1 commit intoeprbell:mainfrom
splix wants to merge 1 commit intoeprbell:mainfrom
Conversation
eprbell
approved these changes
Sep 17, 2023
Owner
eprbell
left a comment
eprbell
left a comment
There was a problem hiding this comment.
LGTM: thanks for submitting the PR!
eprbell
requested changes
Sep 17, 2023
Owner
eprbell
left a comment
eprbell
left a comment
There was a problem hiding this comment.
I spoke too soon: there are a few unit test failures. Also the documentation failure is due to a dead link: I disabled the check for it, so if you rebase the code it should go away.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #101