Libmodbuspp ascii support #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccdMuro
force-pushed
the
libmodbuspp-ascii-support
branch
2 times, most recently
from
e4e748f to
da87df5
Compare
tamara-schmitz
force-pushed
the
libmodbuspp-ascii-support
branch
3 times, most recently
from
f960c16 to
f6f7c9a
Compare
tamara-schmitz
force-pushed
the
libmodbuspp-ascii-support
branch
2 times, most recently
from
e521bf9 to
b0ec07e
Compare
Throw exceptions on error instead of silently changing values. Check settings string for given stop bit value. Up until now, the stop bits value was hard coded to be 2 if the parity mode was set to none or 1 if the parity mode was set to even or odd. So a setting of "115200E1" would result in a stop bit value of 1. But "115200E2" would result also in a stop bit value of 1. And "115200N1" would result in a stop bit value of 2. This is not a restriction of libmodbus. The library supports all these modes just fine. In fact they are using 115200N1 in the documentation for modbus_new_rtu(). Rather this is a bug in the string parsing that libmodbuspp introduces in its constructor. libmodbus has no string parsing in modbus_new_rtu() and takes in the arguments as parameters directly. Fixes: b0f3dc4
…calls to ensure the defines are set correctly
…with version 3.1.8; remove dependency in default libmodbus
…h instead (works better with bitbake)
…n INSTALL_TEMPLATES default OFF
…es use of methods and lambda captures
…ke modbus_t a unique_ptr
…tiple instances with a single poll
tamara-schmitz
force-pushed
the
libmodbuspp-ascii-support
branch
from
b0ec07e to
a81892c
Compare
(re-)added virtual destructors to prevent memory leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a branch with ascii support which depends exclusively on the modbusepsi library with ascii-support (starting with v3.1.8) as the default libmodbus does not support ascii mode.
I also made some modifications to the installation so I can use it with bitbake, but tried not to break the default behavior if used for desktop.