Change Proof inner representation from Vec<u32> to Vec<u8>#3289
Merged
vbar merged 1 commit intoeqlabs:mainfrom Mar 24, 2026
Merged
Change Proof inner representation from Vec<u32> to Vec<u8>#3289vbar merged 1 commit intoeqlabs:mainfrom
vbar merged 1 commit intoeqlabs:mainfrom
Conversation
CHr15F0x
reviewed
Mar 23, 2026
CHr15F0x
reviewed
Mar 23, 2026
…of type with recent p2p spec
vbar
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the inner representation of the
Prooftype fromVec<u32>toVec<u8>across RPC,gateway, and P2P layers.
Rationale
The proof is now compressed before being attached to the transaction, making it an opaque byte blob
rather than a sequence of
u32values. This was a last-minute change on the gateway side.Spec references:
starknet-io/starknet-p2p-specs@411d992
Changes
crates/common/src/lib.rs—Proof(Vec<u32>)→Proof(Vec<u8>); simplified serde to directbase64 encode/decode (no more u32 packing, no multiple-of-4 validation)
crates/rpc/src/dto/primitives.rs— removed intermediateu32 → big-endian bytesconversionstep in DTO serialization
crates/p2p_proto/proto/transaction.proto—repeated uint32 proof→bytes proofinInvokeV3WithProofcrates/p2p_proto/src/transaction.rs—proof: Vec<u32>→proof: Vec<u8>crates/rpc/fixtures/0.10.0/broadcasted_transactions.json— updated expected base64 valueNotes
repeated uint32→bytes)prooffield remains transient: accepted from clients, forwarded to the sequencer, propagatedvia mempool/consensus P2P, but never stored in the DB or included in the transaction hash (only
proof_factsare)