fix(storage): class definition placeholder rows not filled (or detected) correctly#3297
Open
fix(storage): class definition placeholder rows not filled (or detected) correctly#3297
Conversation
zvolin
approved these changes
Mar 24, 2026
CHr15F0x
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related bugs in
class_definitionshandling:class_definitions_existreturned true for placeholder rows (rows withdefinition IS NULL), causing definitions to never be re-fetched for classes whose placeholder was created before the definition arrived.insert_cairo_class_definitionandinsert_sierra_class_definitionusedINSERT OR IGNORE, which silently dropped writes when a placeholder row already existed for the hash. Replaced with an upsert that fills a NULL definition without overwriting an existing one.All three functions now correctly treat a row with
definition IS NULLas absent.See also #3287