Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the verify_mutants feature from the mutation testing toolset. The feature previously allowed verification that generated mutants could successfully compile before being saved, but this capability is being removed entirely.
- Removed the
verify_mutantsCLI option from bothmove-mutatorandmove-spec-testtools - Deleted the
verify_mutantfunction and its associated verification logic from the codebase - Updated tests to no longer set or test the
verify_mutantsoption
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| move-spec-test/src/cli.rs | Removed verify_mutants CLI option and its usage in mutator options creation |
| move-mutator/tests/basic_tests.rs | Removed verify_mutants field from test configurations |
| move-mutator/src/lib.rs | Removed mutant verification logic and the import of verify_mutant function |
| move-mutator/src/compiler.rs | Removed the entire verify_mutant function (~65 lines) and its associated unused imports |
| move-mutator/src/cli.rs | Removed verify_mutants CLI option and its default value |
| move-mutation-test/src/cli.rs | Removed verify_mutants setting when creating mutator options |
Comments suppressed due to low confidence (3)
move-mutator/src/compiler.rs:1
- The
fs_extra::dir::CopyOptionsimport is now unused after the removal of theverify_mutantfunction. This import should be removed, but note thatfs_extrais still used elsewhere in the codebase (tests, other modules), so only this import line should be removed from this file.
// Copyright © Eiger
move-mutator/tests/basic_tests.rs:75
- The test function name
check_mutator_verify_mutants_correctlyis misleading as it no longer tests mutant verification functionality (theverify_mutantsoption has been removed). The test now only validates basic mutator functionality. Consider renaming this test to better reflect its actual purpose, such ascheck_mutator_works_on_poor_spec_package.
fn check_mutator_verify_mutants_correctly() {
move-mutator/tests/basic_tests.rs:180
- The comment above the
check_mutator_fails_verify_file_without_packagefunction is now outdated and incorrect. It references verification being enabled, but theverify_mutantsoption has been removed. The test now appears to verify that mutants can be generated for files without a package, and the assertionassert!(report.get_mutants().is_empty())suggests it expects zero mutants. The comment should be updated to accurately describe what this test actually validates.
// Check if the mutator produce zero mutants if verification is enabled for
// files without any package (we're unable to verify such files successfully).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ] | ||
| }, | ||
| "package_dir": "/Users/jos/Projects/move-mutation-tools/move-mutator/tests/move-assets/simple" | ||
| "package_dir": "/home/jos/Projects/move-mutation-tools/move-mutator/tests/move-assets/simple" |
There was a problem hiding this comment.
These always result in conflicts. I think we don't use package_dir anywhere. So we should be good to delete it completely from the report.
You can do that if you want and have the time, but it's not critical at all.
* feat: remove verify_mutants (#136) * feat: remove verify_mutants * fix: remove this test that is now obsolete * fix: tests * Feat/fail fast (#137) * feat: make work on aptos main branch * feat: fail-fast * chore: switch to aptos 1.38 release branch * chore: update lock file * fix: improve doc comment * bump to aptos v1.38.2
Remove this flag as it massively slows down generation of the mutants.