Skip to content

feat: remove verify_mutants#136

Merged
joske merged 3 commits intodev-m3from
feat/remove-verify-mutants
Nov 10, 2025
Merged

feat: remove verify_mutants#136
joske merged 3 commits intodev-m3from
feat/remove-verify-mutants

Conversation

@joske
Copy link
Copy Markdown
Contributor

@joske joske commented Nov 10, 2025

Remove this flag as it massively slows down generation of the mutants.

@joske joske requested review from Copilot and ctoyan November 10, 2025 08:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the verify_mutants feature from the mutation testing toolset. The feature previously allowed verification that generated mutants could successfully compile before being saved, but this capability is being removed entirely.

  • Removed the verify_mutants CLI option from both move-mutator and move-spec-test tools
  • Deleted the verify_mutant function and its associated verification logic from the codebase
  • Updated tests to no longer set or test the verify_mutants option

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
move-spec-test/src/cli.rs Removed verify_mutants CLI option and its usage in mutator options creation
move-mutator/tests/basic_tests.rs Removed verify_mutants field from test configurations
move-mutator/src/lib.rs Removed mutant verification logic and the import of verify_mutant function
move-mutator/src/compiler.rs Removed the entire verify_mutant function (~65 lines) and its associated unused imports
move-mutator/src/cli.rs Removed verify_mutants CLI option and its default value
move-mutation-test/src/cli.rs Removed verify_mutants setting when creating mutator options
Comments suppressed due to low confidence (3)

move-mutator/src/compiler.rs:1

  • The fs_extra::dir::CopyOptions import is now unused after the removal of the verify_mutant function. This import should be removed, but note that fs_extra is still used elsewhere in the codebase (tests, other modules), so only this import line should be removed from this file.
// Copyright © Eiger

move-mutator/tests/basic_tests.rs:75

  • The test function name check_mutator_verify_mutants_correctly is misleading as it no longer tests mutant verification functionality (the verify_mutants option has been removed). The test now only validates basic mutator functionality. Consider renaming this test to better reflect its actual purpose, such as check_mutator_works_on_poor_spec_package.
fn check_mutator_verify_mutants_correctly() {

move-mutator/tests/basic_tests.rs:180

  • The comment above the check_mutator_fails_verify_file_without_package function is now outdated and incorrect. It references verification being enabled, but the verify_mutants option has been removed. The test now appears to verify that mutants can be generated for files without a package, and the assertion assert!(report.get_mutants().is_empty()) suggests it expects zero mutants. The comment should be updated to accurately describe what this test actually validates.
// Check if the mutator produce zero mutants if verification is enabled for
// files without any package (we're unable to verify such files successfully).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joske joske changed the base branch from main to dev-m3 November 10, 2025 09:31
]
},
"package_dir": "/Users/jos/Projects/move-mutation-tools/move-mutator/tests/move-assets/simple"
"package_dir": "/home/jos/Projects/move-mutation-tools/move-mutator/tests/move-assets/simple"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These always result in conflicts. I think we don't use package_dir anywhere. So we should be good to delete it completely from the report.
You can do that if you want and have the time, but it's not critical at all.

@joske joske merged commit c921ca7 into dev-m3 Nov 10, 2025
4 checks passed
@joske joske deleted the feat/remove-verify-mutants branch November 10, 2025 11:01
joske added a commit that referenced this pull request Dec 2, 2025
* feat: remove verify_mutants (#136)

* feat: remove verify_mutants

* fix: remove this test that is now obsolete

* fix: tests

* Feat/fail fast (#137)

* feat: make work on aptos main branch

* feat: fail-fast

* chore: switch to aptos 1.38 release branch

* chore: update lock file

* fix: improve doc comment

* bump to aptos v1.38.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants