Conversation
anstylian
force-pushed
the
ci
branch
5 times, most recently
from
b4645ae to
95edea9
Compare
- Add CI workflow for linting, formatting, testing, and building - Add custom actions for patched dependencies and protoc setup - Add markdownlint, yamllint, and typos configuration files - Update workspace Rust MSRV to 1.88.0 in Cargo.toml
…th filtering - Switch CI trigger from push to pull_request (opened, synchronize, reopened)
- Refactor GitHub Actions workflow to run full CI only when PR is ready for review, in merge queue, or manually triggered. - Remove incremental path filtering and related jobs.
Replaced individual `license = "MIT"` entries with `license.workspace = true` in Cargo.toml files for consistency and centralized license management.
asmie
approved these changes
Jan 12, 2026
asmie
left a comment
asmie
left a comment
There was a problem hiding this comment.
LGTM.
Small nitpicks.
Generally you repeat the same “Checkout / Install protoc / Setup patched deps / Install toolchain / rustup override / cache” blocks in multiple jobs. Consider extracting into a reusable workflow or a composite action (you already have internal actions like setup-protoc and setup-patched-deps, so you’re aligned with this approach).
…or CI workflow - Add `.github/actions/setup-rust-build/action.yml` composite action to install protoc, setup patched dependencies, install Rust toolchain, and configure cache. - Refactor `.github/workflows/ci.yml` to use the new composite action, simplify job dependencies, and clarify PR trigger events.
asmie
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #12