Skip to content

WIP: rebasing distance esmda - not for merge#12837

Closed
xjules wants to merge 2 commits intoequinor:mainfrom
xjules:desmda_entry_rebased
Closed

WIP: rebasing distance esmda - not for merge#12837
xjules wants to merge 2 commits intoequinor:mainfrom
xjules:desmda_entry_rebased

Conversation

@xjules
Copy link
Contributor

@xjules xjules commented Feb 10, 2026

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@xjules xjules force-pushed the desmda_entry_rebased branch from 1a4fb75 to 3d3ee2a Compare February 11, 2026 08:22
- Snapshots for heat eq.
- Update heq figure
- Add obs_loc to hq
 - Add tests for DistanceESMDA
 - Add obs with locs in snake_oil_field
@xjules xjules force-pushed the desmda_entry_rebased branch from 3d3ee2a to ac882d9 Compare February 11, 2026 08:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 85.18519% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.65%. Comparing base (e9cbe0b) to head (ac882d9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ert/analysis/_es_update.py 84.90% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12837      +/-   ##
==========================================
- Coverage   90.70%   90.65%   -0.06%     
==========================================
  Files         436      437       +1     
  Lines       30350    30413      +63     
==========================================
+ Hits        27529    27570      +41     
- Misses       2821     2843      +22     
Flag Coverage Δ
cli-tests 37.27% <85.18%> (+0.19%) ⬆️
gui-tests 68.30% <35.18%> (-0.03%) ⬇️
performance-and-unit-tests 77.04% <35.18%> (-0.10%) ⬇️
test 37.35% <11.11%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 11, 2026

Merging this PR will not alter performance

✅ 34 untouched benchmarks


Comparing xjules:desmda_entry_rebased (ac882d9) with main (0cf1c26)

Open in CodSpeed

@xjules
Copy link
Contributor Author

xjules commented Feb 13, 2026

closing this one

@xjules xjules closed this Feb 13, 2026
@xjules xjules deleted the desmda_entry_rebased branch February 13, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants