Skip to content

Update ies API calls for DistanceESMDA#12858

Merged
xjules merged 2 commits intoequinor:mainfrom
xjules:fix_api_desmda
Feb 12, 2026
Merged

Update ies API calls for DistanceESMDA#12858
xjules merged 2 commits intoequinor:mainfrom
xjules:fix_api_desmda

Conversation

@xjules
Copy link
Contributor

@xjules xjules commented Feb 12, 2026

Attribute name change:
X_prior -> X

Approach
🚗

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@xjules xjules self-assigned this Feb 12, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (0969869) to head (07d9aba).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12858      +/-   ##
==========================================
- Coverage   90.64%   90.63%   -0.02%     
==========================================
  Files         440      440              
  Lines       30468    30468              
==========================================
- Hits        27618    27614       -4     
- Misses       2850     2854       +4     
Flag Coverage Δ
cli-tests 37.23% <100.00%> (ø)
gui-tests 67.89% <0.00%> (+0.02%) ⬆️
performance-and-unit-tests 77.04% <0.00%> (-0.02%) ⬇️
test 37.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xjules xjules merged commit 3f19861 into equinor:main Feb 12, 2026
56 of 68 checks passed
@xjules xjules deleted the fix_api_desmda branch February 12, 2026 15:52
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2026

Merging this PR will not alter performance

✅ 34 untouched benchmarks


Comparing xjules:fix_api_desmda (07d9aba) with main (0969869)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants