Conversation
Collaborator
Author
|
See #102 |
larsevj
force-pushed
the
warn_about_legacy_installs
branch
from
52cbbb2 to
6f28e3e
Compare
larsevj
force-pushed
the
warn_about_legacy_installs
branch
from
6f28e3e to
9dbddce
Compare
berland
reviewed
Sep 22, 2025
src/komodoenv/__main__.py
Outdated
| "If you encounter issues with the Jupyter environment or the 'rips' package, try " | ||
| "running 'komodoenv-update' or sourcing the komodoenv again.\n" | ||
| "Only legacy editable installs are supported for packages that are also present in komodo. " | ||
| "Use option '--config-settings editable_mode=compat' to enforce this via pip.\n" |
Contributor
There was a problem hiding this comment.
Can this sentence be more explicit that this is a pip option?
Collaborator
Author
There was a problem hiding this comment.
It will also work for uv, it is just passed through to the pep517 build backend (setuptools in this case).
Have updated the wording now.
larsevj
force-pushed
the
warn_about_legacy_installs
branch
from
9dbddce to
3178d67
Compare
berland
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre review checklist
Ground Rules),
and changes to existing code have good test coverage.
Pre merge checklist