New SimulationTimeSeriesOneByOne plugin#1217
Merged
lindjoha merged 19 commits intoequinor:masterfrom May 22, 2023
Merged
Conversation
added 14 commits
May 15, 2023 10:55
… to avoid problems with other plugins
added 2 commits
May 15, 2023 10:59
11 tasks
tnatt
approved these changes
May 19, 2023
Collaborator
tnatt
left a comment
tnatt
left a comment
There was a problem hiding this comment.
LGTM. Tested and works fine. No big comments from me 🙂
- Update the plugin description
- Could be nice with a resampling option box
- Clean up the timeseries figure function by dropping unused parts
from other users I have gotten request to be able to filter the tornado when using the sensitivity filter. I had a plan to make a checkbox to "link sensitivity filter". You can include it if you have time 😃
I also guess it would be nice to show the the p10/p90 lines instead of/together with the mean for mc sensitivities. so that it follows the tornado plot bars. but that probably requires a bit more time, and could be put as an issue
webviz_subsurface/plugins/_simulation_time_series_onebyone/_plugin.py
Outdated
Show resolved
Hide resolved
...iz_subsurface/plugins/_simulation_time_series_onebyone/_utils/_onebyone_timeseries_figure.py
Outdated
Show resolved
Hide resolved
...iz_subsurface/plugins/_simulation_time_series_onebyone/_utils/_onebyone_timeseries_figure.py
Outdated
Show resolved
Hide resolved
...lugins/_simulation_time_series_onebyone/_utils/_simulation_time_series_onebyone_datamodel.py
Outdated
Show resolved
Hide resolved
...lugins/_simulation_time_series_onebyone/_utils/_simulation_time_series_onebyone_datamodel.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New plugin
SimulationTimeSeriesOneByOne, mean to replace the old pluginReservoirSimulationTimeSeriesOneByOne. Based on #1156 by @tnatt, but converted to the WLF framework.Uses the arrow summary provider and has a bit more functionality than the old plugin.
Contributor checklist
.UNSMRYto.arrowprovider #858 forSimulationTimeSeriesOneByOneCHANGELOG.md, and added it if should be communicated there.