Skip to content

[cleanup] Remove unneeded StdToWX::ToArrayString calls#3854

Merged
eranif merged 3 commits intoeranif:masterfrom
Jarod42:stdToWx_ToArrAyString
Mar 15, 2026
Merged

[cleanup] Remove unneeded StdToWX::ToArrayString calls#3854
eranif merged 3 commits intoeranif:masterfrom
Jarod42:stdToWx_ToArrAyString

Conversation

@Jarod42
Copy link
Copy Markdown
Collaborator

@Jarod42 Jarod42 commented Feb 28, 2026

No description provided.

@Jarod42 Jarod42 force-pushed the stdToWx_ToArrAyString branch from 9849b61 to e8def21 Compare March 10, 2026 08:10
@eranif
Copy link
Copy Markdown
Owner

eranif commented Mar 12, 2026

Is this supported in wx3.2 on all build types or does it require an STL build of wxWidgets? (which in this case, wxArrayString is a subclass of class wxBaseArray : public wxVector<T> ? (where wxVector is using wxVector = std::vector<T>;)

@Jarod42
Copy link
Copy Markdown
Collaborator Author

Jarod42 commented Mar 12, 2026

Not sure, I will add a CI build with wxUseSTL=0 (or --disable-stl) to check.

@Jarod42 Jarod42 marked this pull request as draft March 12, 2026 18:32
@Jarod42 Jarod42 marked this pull request as ready for review March 13, 2026 22:13
@Jarod42
Copy link
Copy Markdown
Collaborator Author

Jarod42 commented Mar 13, 2026

Added only to macOS CI (--disable-stl) and it passes :-)

@Jarod42 Jarod42 force-pushed the stdToWx_ToArrAyString branch from bee0dc3 to 460d389 Compare March 14, 2026 16:27
@eranif eranif merged commit 6c32c9f into eranif:master Mar 15, 2026
8 checks passed
@Jarod42 Jarod42 deleted the stdToWx_ToArrAyString branch March 15, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants