Conversation
|
I add Czech/French/Japanese/Russian language to the installer. Please merge it and test new instalelr. |
CI on msys provides the installer as artefact for easy testing. |
|
Just tested the French version. There is the custom message: which doesn't use the section CustomMessage. See how-to-translate-texts-contained-in-msgbox-in-inno-setup. |
|
Where did you get (link) the new installer? I added in my PR the two custom messages strings about MsgBox commands with translation for English/French/Italian If you can please merge the inno Setup script changes. |
| eng.KeepUserSettings=Would you like to keep your user settings? | ||
| eng.KeepLocalSettings=Would you like to keep your local settings? | ||
|
|
||
| eng.KeepUserSettings=Souhaitez-vous conserver vos paramètres utilisateur? |
There was a problem hiding this comment.
Yes sure. Copy/paste error.
|
Where did you get temporary installer build? |
As artefact of the action build: https://github.com/eranif/codelite/actions/workflows/msys2.yml You might also activate them in your cloned repo; to test them before opening PR. Ubuntu actions provide .pot for translations |
InnoSetup/codelite64_mingw.iss.in
Outdated
| #define SupportURL "https://codelite.org" | ||
|
|
||
| ; external file with language and custom message definitions | ||
| #include "codelite64_mingw.localization.iss.in" |
There was a problem hiding this comment.
The .in is for template for file generation (i.e in CMAke, configure_file(${CL_SRC_ROOT}/InnoSetup/codelite64_mingw.iss.in ${BUILD_DIRECTORY}/codelite64_mingw.iss) which replace placeholder as @CODELITE_VERSION@).
That localization file doesn't have placeholders to replace.
There was a problem hiding this comment.
There was a problem hiding this comment.
I meant codelite64_mingw.localization.iss.in should be renamed into codelite64_mingw.localization.iss.
Local path looks better IMO but from https://github.com/eranif/codelite/actions/runs/23184910992/job/67369133019?pr=3872
Built target codelite-install
Inno Setup 6 Command-Line Compiler
Copyright (C) 1997-2025 Jordan Russell. All rights reserved.
Portions Copyright (C) 2000-2025 Martijn Laan. All rights reserved.
Portions Copyright (C) 2001-2004 Alex Yackimoff. All rights reserved.
https://www.innosetup.com/
Compiler engine version: Inno Setup 6.6.1
Non-commercial use only
Preprocessing
Reading file: C:\Program Files (x86)\Inno Setup 6\ISPPBuiltins.iss
Error on line 10 in C:\a\codelite\codelite\build-release\codelite64_mingw.iss: File not found: codelite64_mingw.localization.iss.in.
Compile aborted.
So adjust include path or possibly use absolute path as you suggested.
There was a problem hiding this comment.
This line should be changed into:
#include "@CL_SRC_ROOT@/InnoSetup/codelite64_mingw.localization.iss.in"
During cmake stage the file codelite64_mingw.iss.in is going into a configure stage and all variables with @ around them are being replaced.
InnoSetup/codelite64_mingw.iss.in
Outdated
| #define SupportURL "https://codelite.org" | ||
|
|
||
| ; external file with language and custom message definitions | ||
| #include "codelite64_mingw.localization.iss.in" |
There was a problem hiding this comment.
This line should be changed into:
#include "@CL_SRC_ROOT@/InnoSetup/codelite64_mingw.localization.iss.in"
During cmake stage the file codelite64_mingw.iss.in is going into a configure stage and all variables with @ around them are being replaced.
|
PR updated. |
|
Thanks @bovirus - I re-activated the workflows. |
|
I added Italian language Installer creation error. mingw32-make[2]: *** No rule to make target 'translations/it/codelite.po', needed by 'translations/it-codelite.gmo'. Stop. |
@eranif
Please check if it's ok now and merge it. Thanks.