Skip to content

Installer script improvements#3872

Merged
eranif merged 10 commits intoeranif:masterfrom
bovirus:master
Mar 17, 2026
Merged

Installer script improvements#3872
eranif merged 10 commits intoeranif:masterfrom
bovirus:master

Conversation

@bovirus
Copy link
Copy Markdown
Contributor

@bovirus bovirus commented Mar 16, 2026

@eranif

Please check if it's ok now and merge it. Thanks.

@bovirus
Copy link
Copy Markdown
Contributor Author

bovirus commented Mar 16, 2026

@eranif

I add Czech/French/Japanese/Russian language to the installer.
For the Chinese (not included by default in Inno Setup) you should add and external .ISL file.

Please merge it and test new instalelr.

@Jarod42
Copy link
Copy Markdown
Collaborator

Jarod42 commented Mar 16, 2026

Please merge it and test new installer.

CI on msys provides the installer as artefact for easy testing.

@Jarod42
Copy link
Copy Markdown
Collaborator

Jarod42 commented Mar 16, 2026

Just tested the French version.

There is the custom message:

if MsgBox('Would you like to keep your user settings?'

which doesn't use the section CustomMessage.

See how-to-translate-texts-contained-in-msgbox-in-inno-setup.

@bovirus
Copy link
Copy Markdown
Contributor Author

bovirus commented Mar 17, 2026

@Jarod42

Where did you get (link) the new installer?
Thanks for explanation about MsgBox.

@eranif

I added in my PR the two custom messages strings about MsgBox commands with translation for English/French/Italian
For a better handling I created a separate Inno Setup script file with just languages and custom messages defintion.
In this way is better to maintain language and custom messages without touch main installer script.

If you can please merge the inno Setup script changes.

eng.KeepUserSettings=Would you like to keep your user settings?
eng.KeepLocalSettings=Would you like to keep your local settings?

eng.KeepUserSettings=Souhaitez-vous conserver vos paramètres utilisateur?
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be fra ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure. Copy/paste error.

@bovirus
Copy link
Copy Markdown
Contributor Author

bovirus commented Mar 17, 2026

@eranif

Where did you get temporary installer build?

@Jarod42
Copy link
Copy Markdown
Collaborator

Jarod42 commented Mar 17, 2026

Where did you get (link) the new installer?

As artefact of the action build:

https://github.com/eranif/codelite/actions/workflows/msys2.yml

You might also activate them in your cloned repo; to test them before opening PR.

Ubuntu actions provide .pot for translations

#define SupportURL "https://codelite.org"

; external file with language and custom message definitions
#include "codelite64_mingw.localization.iss.in"
Copy link
Copy Markdown
Collaborator

@Jarod42 Jarod42 Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .in is for template for file generation (i.e in CMAke, configure_file(${CL_SRC_ROOT}/InnoSetup/codelite64_mingw.iss.in ${BUILD_DIRECTORY}/codelite64_mingw.iss) which replace placeholder as @CODELITE_VERSION@).

That localization file doesn't have placeholders to replace.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarod42
I believe that when you run main ino Setup script it should load the other ones with language/custom emssages definition. Or we should change it in

#include "${CL_SRC_ROOT}/InnoSetup/codelite64_mingw.localization.iss.in"

@eranif
Is it the change to do?

Copy link
Copy Markdown
Collaborator

@Jarod42 Jarod42 Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant codelite64_mingw.localization.iss.in should be renamed into codelite64_mingw.localization.iss.
Local path looks better IMO but from https://github.com/eranif/codelite/actions/runs/23184910992/job/67369133019?pr=3872

Built target codelite-install
Inno Setup 6 Command-Line Compiler
Copyright (C) 1997-2025 Jordan Russell. All rights reserved.
Portions Copyright (C) 2000-2025 Martijn Laan. All rights reserved.
Portions Copyright (C) 2001-2004 Alex Yackimoff. All rights reserved.
https://www.innosetup.com/

Compiler engine version: Inno Setup 6.6.1
Non-commercial use only

Preprocessing
   Reading file: C:\Program Files (x86)\Inno Setup 6\ISPPBuiltins.iss
Error on line 10 in C:\a\codelite\codelite\build-release\codelite64_mingw.iss: File not found: codelite64_mingw.localization.iss.in.
Compile aborted.

So adjust include path or possibly use absolute path as you suggested.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be changed into:

#include             "@CL_SRC_ROOT@/InnoSetup/codelite64_mingw.localization.iss.in"

During cmake stage the file codelite64_mingw.iss.in is going into a configure stage and all variables with @ around them are being replaced.

#define SupportURL "https://codelite.org"

; external file with language and custom message definitions
#include "codelite64_mingw.localization.iss.in"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be changed into:

#include             "@CL_SRC_ROOT@/InnoSetup/codelite64_mingw.localization.iss.in"

During cmake stage the file codelite64_mingw.iss.in is going into a configure stage and all variables with @ around them are being replaced.

@bovirus
Copy link
Copy Markdown
Contributor Author

bovirus commented Mar 17, 2026

@eranif

PR updated.
Now should be OK.

@eranif
Copy link
Copy Markdown
Owner

eranif commented Mar 17, 2026

Thanks @bovirus - I re-activated the workflows.

@bovirus
Copy link
Copy Markdown
Contributor Author

bovirus commented Mar 17, 2026

@eranif

I added Italian language
I created "it" subfolfer
I copied codelite.po
I modify cmake as explained.
But probably is not enough. Please check.

Installer creation error.

mingw32-make[2]: *** No rule to make target 'translations/it/codelite.po', needed by 'translations/it-codelite.gmo'. Stop.
mingw32-make[1]: *** [CMakeFiles\Makefile2:4819: translations/CMakeFiles/pofiles_3.dir/all] Error 2

@eranif eranif requested review from Jarod42 and eranif March 17, 2026 18:16
@eranif eranif merged commit cc64d17 into eranif:master Mar 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants