broad and sharp crested weir fixes#143
Open
cekees wants to merge 45 commits intolmaurel/general_update_reviewfrom
Open
broad and sharp crested weir fixes#143cekees wants to merge 45 commits intolmaurel/general_update_reviewfrom
cekees wants to merge 45 commits intolmaurel/general_update_reviewfrom
Conversation
Something is not quite right since the bar is drifting in x-y right now even when constrained to the 3DOF z,rx,ry.
works with proteus d6bd37f210bf60e1f6760b2db77701bf68b9f5a0
- free_x cancels gravity force if set to 0 - addSpring: for moorings - setPosition - setRotation - setConstraints - setInertiaXX
use C++ std shared pointers fixed collision with walls
- added spherical link on fairlead with prismatic links - spring is disabled if length < rest length - external forces can be applied without proteus for testing - cleaning up of some logic
- fixed chrono sub time step - added chrono system options (solver, time integration, etc) - more context options - can choose between backward Euler and VBDF of order 2
…o tridelat/sphere
…nto cekees/tutorials
Contributor
|
👍 The large discharge shows why we would need a vent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added several more tweaks to the broad and sharp crested weir.
