Conversation
…' into cekees/marin3p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the test in the 3d/marin3p folder. It depends on erdc/proteus#683 and is in need of several improvements:
he,genMesh,openTop,...)extractMarinHeight.pyandextractMarinPressure.py. Since those scripts pull from the xdmf, the extracted data are dependent on the user's selection of output times, and the pararview scripts don't seem to work as-is for rans3p's mixed FEM spaces anyway.openTopoption--right now this is running with closed boundaries*.datfiles./cc @arnsong @manuel-quezada @wacyyang @westb @Giovanni-Cozzuto-1989 @Pedrohrw