-
Notifications
You must be signed in to change notification settings - Fork 10
Fix discovery of @maximumDuration
annotation when test-cases have no test methods
#687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix discovery of @maximumDuration
annotation when test-cases have no test methods
#687
Conversation
230dec9
to
cd7cbfe
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
============================================
- Coverage 57.86% 57.62% -0.25%
Complexity 135 135
============================================
Files 33 33
Lines 712 715 +3
============================================
Hits 412 412
- Misses 300 303 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
52d28c0
to
cc61a4c
Compare
4777ea0
to
bfaa3bb
Compare
bfaa3bb
to
3d341a6
Compare
f15a1d3
to
f51937a
Compare
Hey @localheinz , Are you able to approve the workflow? I apologise for the revisions -- I think I exceeded some limit. The full suite of tests for all versions does not run locally for myself. I think the code changes are good, but getting the test expectations correct has been trial and error. |
Apologies for the delay! |
f51937a
to
fbf30fd
Compare
Heya @localheinz , Just another nudge to approve this workflow. I'm hoping I have the tests expectations correct this time 🤞 |
This fixes a warning triggered when discovering the maximum duration for a test-case class that has no test methods.
Fixes #686