Skip to content

Conversation

courtney-miles
Copy link

This fixes a warning triggered when discovering the maximum duration for a test-case class that has no test methods.

Fixes #686

@courtney-miles courtney-miles force-pushed the fix-warning-for-testname-without-method branch from 230dec9 to cd7cbfe Compare May 20, 2025 07:56
@localheinz localheinz self-assigned this May 24, 2025
@localheinz localheinz added the bug label May 24, 2025
Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 57.62%. Comparing base (8ff9c0b) to head (f51937a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/Extension.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #687      +/-   ##
============================================
- Coverage     57.86%   57.62%   -0.25%     
  Complexity      135      135              
============================================
  Files            33       33              
  Lines           712      715       +3     
============================================
  Hits            412      412              
- Misses          300      303       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz force-pushed the fix-warning-for-testname-without-method branch 2 times, most recently from 52d28c0 to cc61a4c Compare May 24, 2025 10:53
localheinz
localheinz previously approved these changes May 24, 2025
@localheinz localheinz force-pushed the fix-warning-for-testname-without-method branch 3 times, most recently from 4777ea0 to bfaa3bb Compare May 24, 2025 11:33
@localheinz localheinz force-pushed the fix-warning-for-testname-without-method branch from bfaa3bb to 3d341a6 Compare May 24, 2025 15:22
localheinz
localheinz previously approved these changes May 24, 2025
@courtney-miles courtney-miles force-pushed the fix-warning-for-testname-without-method branch 3 times, most recently from f15a1d3 to f51937a Compare June 30, 2025 22:41
@courtney-miles
Copy link
Author

Hey @localheinz ,

Are you able to approve the workflow?

I apologise for the revisions -- I think I exceeded some limit.

The full suite of tests for all versions does not run locally for myself. I think the code changes are good, but getting the test expectations correct has been trial and error.

@localheinz
Copy link
Member

Apologies for the delay!

@courtney-miles courtney-miles force-pushed the fix-warning-for-testname-without-method branch from f51937a to fbf30fd Compare July 26, 2025 00:40
@courtney-miles
Copy link
Author

Heya @localheinz ,

Just another nudge to approve this workflow.

I'm hoping I have the tests expectations correct this time 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined array key warning where test-case does not contain any test methods
2 participants