Conversation
aslesarenko
previously requested changes
Apr 26, 2024
|
|
||
| * support MethodCall encoding of Numeric methods | ||
|
|
||
| issue: https://github.com/ScorexFoundation/sigmastate-interpreter/issues/667 |
Member
There was a problem hiding this comment.
Maybe this is not necessary. Looking back is was not good idea to allow both method call and opcode encoding for methods. It would be better to forbid method calls for those methods which have dedicated opcodes.
The translation MC -> opcode is actually happens in the compiler, but is not strictly enforced. This creates more surface for test coverage and potential bugs.
Member
Author
There was a problem hiding this comment.
I think it would be better to develop ErgoTree via adding methods, to have simple universal description of the language.
| * Add roundtrip test in *MethodCallSerializerSpecification* | ||
|
|
||
| * Add evaluation test (see "nbits evaluation" test) | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| * For each new method separate property tests should be added to SigmaDslSpecification. |
kushti
dismissed
aslesarenko’s stale review
Comments addressed, please make another pass
Member
Author
|
@aslesarenko comments addressed , please make another pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.