Fix (#1159): Light node with pruning can't catch up after long shutdown#2273
Open
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Open
Fix (#1159): Light node with pruning can't catch up after long shutdown#2273dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Conversation
…he best full block height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a node with pruning enabled fails to catch up after a long shutdown, resulting in MalformedModifierError: Block section should correspond to a block header that is not pruned yet.
The Problem:
When a node is offline for a period longer than the pruning window (blocksToKeep), the minimalFullBlockHeight (calculated from the network's tip) becomes significantly higher than the node's local bestFullBlockHeight. The shouldDownloadBlockAtHeight validation rule was rejecting any blocks below minimalFullBlockHeight. This prevented the node from downloading the necessary intermediate blocks required to update its state and catch up to the network tip.
The Fix:
Modified shouldDownloadBlockAtHeight in FullBlockPruningProcessor to allow downloading and processing of blocks if they are successors to the current bestFullBlockHeight, even if they fall below the minimalFullBlockHeight. This ensures the node can sequentially process history and update its UTXO set to synchronize with the network.