Fix Issue (#1228): Eliminate offchainRegistry#2274
Open
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Open
Fix Issue (#1228): Eliminate offchainRegistry#2274dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Conversation
…t state management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, the wallet maintains a separate offChainRegistry to track off-chain transactions and boxes. This registry is updated when:
However, the wallet is not notified when transactions are removed from the mempool due to:
This causes the offChainRegistry to become stale, showing boxes that are no longer available in the mempool.
Solution:
Eliminate offChainRegistry entirely and query the mempool directly when off-chain boxes are needed. The wallet already receives ChangedMempool events and maintains mempoolReaderOpt, so we can:
Changes: