Fix #1631: Handle rollback with keepVersions=0 during node restart#2277
Open
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Open
Fix #1631: Handle rollback with keepVersions=0 during node restart#2277dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
When a node is restarted during active sync (where keepVersions is temporarily set to 0), the state restoration fails with a NoSuchElementException in the rollbackTo() method. This occurs because:
Solution:
Modified LDBVersionedStore.rollbackTo() to handle the special case where keepVersions=0 and we're attempting to rollback to the current version. In this scenario, the rollback is treated as a no-op since: