feat(#1722) : add initial wallet height setting to avoid rescanning from genesis#2278
Open
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Open
feat(#1722) : add initial wallet height setting to avoid rescanning from genesis#2278dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, when a wallet is initialized (/wallet/init) or restored (/wallet/restore), the node wallet re-scans the blockchain from height 0 (genesis). This is unnecessary and inefficient, especially for nodes with long blockchain histories.
Root Cause:
The initWallet and restoreWallet methods call recreateRegistry() which deletes and recreates the wallet registry database. The new registry starts at height 0 (EmptyHistoryHeight). When new blocks arrive after wallet initialization, the wallet attempts to scan from height 1 onwards, effectively rescanning the entire blockchain.
Solution:
Set the wallet registry height to the current blockchain height immediately after recreating the registry during wallet initialization/restoration. This ensures the wallet only scans new blocks going forward, not historical blocks.
Changes
:
Behavior
:
This is the correct behavior because: