Fix issue #1870: Add height range filtering to /boxes/unspent endpoint#2284
Open
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Open
Fix issue #1870: Add height range filtering to /boxes/unspent endpoint#2284dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
dimension-drifter wants to merge 1 commit intoergoplatform:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The /wallet/boxes/unspent endpoint currently fetches ALL unspent wallet boxes from the database and then filters them in memory by height parameters (minInclusionHeight and maxInclusionHeight). This is inefficient, especially for wallets with many boxes.
The /wallet/transactions endpoint already implements efficient height-based filtering by querying the database directly with a height range using walletTxsBetween().
Solution:
This PR implements the same pattern for /wallet/boxes/unspent: