Add Docker authentication support for pulling from authenticated repositories #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for pulling models from authenticated Docker repositories using credentials stored by
docker login. Users can now access private or authenticated models using the existing-drflag.Problem
Previously,
llama-servercould only pull models from public Docker repositories. Even if users had valid Docker Hub credentials stored viadocker login, they could not access private or authenticated repositories.Solution
The implementation reads Docker credentials from the standard Docker configuration file (
~/.docker/config.json) and uses them when authenticating with the Docker registry API.How it works
User logs in to Docker Hub (one-time setup):
Pull authenticated models:
The implementation automatically:
~/.docker/config.jsonauth.docker.io)Changes
New Function:
common_docker_get_credentials()~/.docker/config.jsonUSERPROFILE, Unix/macOS viaHOME)std::filesystem::pathfor proper path constructionhttps://index.docker.io/v1/,index.docker.io,docker.ioModified Function:
common_docker_get_token()common_docker_get_credentials()to retrieve stored credentialsAuthorization: Basicheader when requesting tokens from the auth serviceSecurity Features
Backward Compatibility
✅ Public repositories continue to work without authentication
✅ Server works normally when no Docker config exists
✅ Anonymous access remains functional
✅ No changes to command-line interface
✅ Existing workflows unaffected
Testing
Example Use Cases
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ggml.ai/home/REDACTED/work/llama.cpp/llama.cpp/build/bin/test-arg-parser(dns block)huggingface.co/home/REDACTED/work/llama.cpp/llama.cpp/build/bin/test-thread-safety -hf ggml-org/models -hff tinyllamas/stories15M-q4_0.gguf -ngl 99 -p The meaning of life is -n 128 -c 256 -ub 32 -np 4 -t 2(dns block)/home/REDACTED/work/llama.cpp/llama.cpp/build/bin/llama-eval-callback --hf-repo ggml-org/models --hf-file tinyllamas/stories260K.gguf --model stories260K.gguf --prompt hello --seed 42 -ngl 0(dns block)/usr/lib/git-core/git-remote-https origin REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.