Skip to content

Conversation

Copy link

Copilot AI commented Oct 19, 2025

Problem

The repository includes Go code for OCI registry integration in the oci-go/ directory (added in the base commit), but the CI workflow path filters only included C/C++, Swift, Metal, and other source files. This meant that changes to Go files (*.go, go.mod, go.sum) would not trigger CI builds, potentially allowing untested Go code changes to be merged.

Solution

Added Go file patterns to the path filters in the following workflows:

  • build.yml - Main CI build workflow (push and pull_request triggers)
  • build-amd.yml - AMD-specific build workflow (push trigger)
  • release.yml - Release workflow (push trigger)
  • server.yml - Server tests workflow (push and pull_request triggers)

Each workflow now includes:

  • **/*.go - Go source files
  • **/go.mod - Go module definition
  • **/go.sum - Go module checksums

Verification

  • ✅ All modified YAML files validated successfully
  • ✅ Go module in oci-go/ builds without errors
  • ✅ No security issues detected
  • ✅ Code review passed with no issues

Now when Go files are modified, the appropriate CI workflows will trigger and validate the changes, ensuring the same level of testing coverage as other source files in the repository.

Original prompt

Fix all the CI Github Actions builds in this pull request:

@ggml-org/llama.cpp/pull/16667


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

So we can pull from any OCI registry, add authentication, etc.

Add docker-style progress bars and resumable downloads to OCI pulls

Update documentation with progress bars and resumable downloads info

Signed-off-by: Eric Curtin <[email protected]>
Copilot AI changed the title [WIP] Fix CI GitHub Actions builds in pull request Fix CI workflows to trigger on Go file changes Oct 19, 2025
Copilot AI requested a review from ericcurtin October 19, 2025 17:53
Copilot finished work on behalf of ericcurtin October 19, 2025 17:53
@ericcurtin ericcurtin force-pushed the integrate-go-containerregistry-library branch 8 times, most recently from e4b192d to 2935963 Compare October 19, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants