Skip to content

Conversation

Copy link

Copilot AI commented Nov 11, 2025

The pull command was displaying downloading progress and completion messages for all layers. Expected behavior is to show only the final layer's completion status.

Before:

$ model-cli pull ai/smollm2:135M-Q4_K_M
ed5fa30c487b: Downloading [=================================================> ]  105.3MB/105.5MB
ed5fa30c487b: Pull complete
609e2cb599f8: Downloading [================>                                  ]  4.096kB/12.62kB
609e2cb599f8: Pull complete
Model pulled successfully

After:

$ model-cli pull ai/smollm2:135M-Q4_K_M
609e2cb599f8: Pull complete
Model pulled successfully

Changes

  • Modified DisplayProgress() to track the last completed layer instead of emitting progress for all layers
  • Added writeDockerComplete() helper to emit a single completion message after stream processing completes
  • Added test coverage for multi-layer progress display behavior

The implementation buffers layer completion tracking and emits only the final layer's status, matching Docker's behavior for image pulls.

Original prompt

On completion of a pull this should be:

$ cmd/cli/model-cli pull ai/smollm2:135M-Q4_K_M
609e2cb599f8: Pull complete
Model pulled successfully

Instead it's currently:

$ cmd/cli/model-cli pull ai/smollm2:135M-Q4_K_M
ed5fa30c487b: Downloading [=================================================> ] 105.3MB/105.5MB
ed5fa30c487b: Pull complete
609e2cb599f8: Downloading [================> ] 4.096kB/12.62kB
609e2cb599f8: Pull complete

Model pulled successfully


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

ericcurtin and others added 2 commits November 11, 2025 13:38
And remove existing transport implementation

We are gonna implement this in the go-containerregistry layer it's cleaner

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Copilot AI and others added 2 commits November 11, 2025 13:46
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix model pull output for consistency Fix pull command to show only final layer completion Nov 11, 2025
Copilot AI requested a review from ericcurtin November 11, 2025 13:55
@ericcurtin ericcurtin force-pushed the rm-old-resume-implementation branch from edf11d8 to 8ae2d43 Compare November 12, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants