Skip to content

Remove the check for the writability of a file #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ymengesha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the check for the writability of a file #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions Perforce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,23 +341,10 @@ def LogResults(success, message):
else:
WarnUser(message);

def IsFileWritable(in_filename):
if(not in_filename):
return 0

# if it doesn't exist, it's "writable"
if(not os.path.isfile(in_filename)):
return 1

filestats = os.stat(in_filename)[0];
if(filestats & stat.S_IWRITE):
return 1
return 0

# Checkout section
def Checkout(in_filename):
if(IsFileWritable(in_filename)):
return -1, "File is already writable."
if not os.path.isfile(in_filename):
return -1, "File does not exist."

folder_name, filename = os.path.split(in_filename)
isInDepot = IsFileInDepot(folder_name, filename)
Expand All @@ -373,9 +360,6 @@ def on_modified(self, view):
if(not view.file_name()):
return

if(IsFileWritable(view.file_name())):
return

perforce_settings = sublime.load_settings('Perforce.sublime-settings')

# check if this part of the plugin is enabled
Expand Down