feat: check dbl_min_max on Decimal.new method #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmj
reviewed
May 6, 2024
Owner
ericmj
left a comment
ericmj
left a comment
There was a problem hiding this comment.
This check should be on to_float/1 as we still want to be able to represent larger decimal numbers for everything other than float conversion.
lib/decimal.ex
Outdated
|
|
||
| def dbl_min(sign), do: %Decimal{sign: sign, coef: 22_250_738_585_072_014, exp: -324} | ||
| def zero(sign), do: %Decimal{sign: sign, coef: 0, exp: 0} | ||
| def dbl_max(sign), do: %Decimal{sign: sign, coef: 17_976_931_348_623_158, exp: 292} |
Owner
There was a problem hiding this comment.
Let's not add these functions to the public API.
ericmj
approved these changes
May 13, 2024
Collaborator
|
Thank you, apologies for the delay merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#206