Added views::merge view. Similar to set_union#1781
Open
roibarkan wants to merge 5 commits intoericniebler:masterfrom
Open
Added views::merge view. Similar to set_union#1781roibarkan wants to merge 5 commits intoericniebler:masterfrom
roibarkan wants to merge 5 commits intoericniebler:masterfrom
Conversation
Author
|
Can you try to rerun after having dealt with the github actions issue? Do I need to somehow update the pull request to be rebased on top of the github actions fixes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of C++Now's "library in a week" initiative, I've been looking into improving the support of sorted views in the ranges library.
A key missing piece in my opinion is a range-adapter for the merge algorithm. Ideally (and somewhat more meaningful than the other set algorithms) - the merge algorithm can benefit from an ability to take more than 2 input ranges and merge them.
More information: https://docs.google.com/presentation/d/1Wiz6fr_6RMnf7hvuf3EilZV-cU5Z9eMJW0rb8Zyq274/preview
This pull request simply adds merge() as a two-input view, similar to the rest of the set-operation views in ranges-v3.
I plan to work on adding this algorithm to boost.algorithm as well, enhance it to support multiple inputs, and am considering proposing it for standardization.