Add state caches that persist throughuout blocks #18868
Open
+1,688
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giulio2002
requested review from
AskAlexSharov,
mh0lt,
sudeepdino008 and
yperbasis
as code owners
- Remove code cache creation in exec3.go to prevent stale cache data between block generation and execution phases - Simplify ValidateAndPrepare to only clear on actual hash mismatch - Remove code cache integration from domain_shared.go GetLatest (cache management should happen at higher level) This fixes TestDeleteRecreateSlotsAcrossManyBlocks which was failing due to stale cached code being returned after selfdestruct/recreate. Co-Authored-By: Claude Opus 4.5 <[email protected]>
…appings This improves the code cache design: - Level 1: addr→codeHash (262144 entries, mutable, cleared on reorg) - Level 2: codeHash→code (2048 entries, immutable, never cleared) Multiple addresses can share the same code (common with proxies/clones), and code hash is immutable so the same hash always means same code. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Prints cache sizes and hit rates at the end of each block: - addr cache: hits/total (hit%) size - code cache: hits/total (hit%) size Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Don't populate cache for addresses already dirty in current block - Capture dirty state at start of GetCode/GetCodeSize before getStateObject - This prevents re-caching code after Selfdestruct removes the entry - Fixes TestCVE2020_26265 and TestSelfDestructReceive with cache enabled - Increase DefaultCodeCacheSize to 10_000 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Giulio2002
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.