chore: remove unused committee subscription deps #18877
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozirDmitriy
requested review from
AskAlexSharov,
Giulio2002 and
domiwei
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously CommitteeSubscribeMgmt stored an index DB handle and sentinel client that were never used anymore after moving subscription expiry handling to GossipManager. This left dead dependencies, extra coupling, and made construction and testing of the component heavier than necessary.
This change removes the unused indiciesDB and sentinel fields and parameters from CommitteeSubscribeMgmt and updates the single constructor call in caplin run.go accordingly, keeping only the dependencies that are actually required for committee subscription management.