common/cypto/ecies: Reject invalid curve public keys early in RLPx ECIES handshake #18880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sahil-4555
requested review from
AskAlexSharov,
Giulio2002,
taratorio and
yperbasis
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds curve validation when generating shared keys in ECIES to ensure invalid public keys are rejected early. The RLPx handshake previously allowed invalid ephemeral public keys to reach the ECDH step and fail later during MAC verification, returning a generic error.
By checking whether the public key lies on the curve before performing ECDH, the handshake now fails immediately with a clear error. The RLPx proof-of-concept test has been updated to verify that invalid curve points are rejected correctly. This improves security by preventing potential invalid-curve and small-subgroup attacks and removes a possible decryption behavior oracle.