Added MovieActivity for opening movie details #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </application> | ||
|
|
||
| </manifest> | ||
| </manifest> No newline at end of file |
| val voteAverage: Int, | ||
| val posterUrl: String, | ||
| val description: String) | ||
| val description: String) : Parcelable |
Owner
There was a problem hiding this comment.
you can create a read it from database using dao en detail instead to use Parcelable
| import io.github.erikjhordanrey.arch_components_paging_library.R | ||
| import io.github.erikjhordanrey.arch_components_paging_library.data.room.Movie | ||
| import io.github.erikjhordanrey.arch_components_paging_library.view.MoviesActivity.Companion.ARG_MOVIE | ||
| import kotlinx.android.synthetic.main.activity_movie.* |
Owner
There was a problem hiding this comment.
remove wildcard imports please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added MovieActivity for opening movie details, added ConstraintLayout, added Glide placeholder.