-
Notifications
You must be signed in to change notification settings - Fork 3k
Add process_info binary_full that provides more details #10265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
CT Test Results 3 files 135 suites 49m 9s ⏱️ Results for commit 44c22ec. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
eb25eca
to
1ca8340
Compare
In particular, this includes the full original binary and all the references. Gathering this information requires full heap traversal, so is fairly expensive - that's why we keep both the existing `binary` and this new API. Example: ``` 1> A = <<0:(1024*8)>>. 2> <<B:550/bitstring,D:550/bits,E:550/bits,C/bitstring>> = A. 3> erlang:process_info(self(),[binary_full]). [{binary_full,[{126812357133856,1024,1, <<0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,...>>, [{1100,1650},{550,1100},{1650,8192},{0,550},{0,8192}]}]}] ``` Co-authored-by: Lukas Backström <[email protected]>
1ca8340
to
39c06bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've left some comments below.
bfb2d9e
to
263de82
Compare
Thank you for the review. I pushed an update addressing your comments. |
In particular, this includes the full original binary and all the references. Gathering this information requires full heap traversal, so is fairly expensive - that's why we keep both the existing
binary
and this new API.Example:
Original draft implementation by @garazdawi in garazdawi@d5a2c6f.