ssl: Fix reversed Certificate Request sign alg order in tls_handshake_1_3:filter_tls13_algs/1#10695
Open
maszlasz wants to merge 1 commit intoerlang:maint-24from
Open
Conversation
|
|
Contributor
CT Test ResultsNo tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured. Results for commit f7b08e7 To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
maszlasz
changed the title
The aforementioned is utilized when preparing the signature algorithm list for the Certificate Request message in a TLS 1.3 handshake, which previously resulted in the list being erroneously reversed. Issue present since OTP 24.
maszlasz
force-pushed
the
msz/maint-24/ssl/fix-sign-alg-req-order
branch
from
f7b08e7 to
6d8e2b2
Compare
Author
|
Hi, not sure if I should open this PR for a newer maint instead, is 24 too old to be updated? I see that the builds have failed due to some deprecations in actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10694.