Do not override private repo urls with default CDN#2346
Open
xurxodiz wants to merge 1 commit intoerlang:mainfrom
Open
Do not override private repo urls with default CDN#2346xurxodiz wants to merge 1 commit intoerlang:mainfrom
xurxodiz wants to merge 1 commit intoerlang:mainfrom
Conversation
Collaborator
|
Ah, so we are taking HEX_CDN to always be defined basically? It should only override if it is actually set. |
Author
|
Keep in mind that at the moment the value read from HEX_CDN is used as fallback endpoint for all repos, so outright taking it out would mean that repos defined without a repo_url themselves (eg. a private hex.pm A more elaborated solution could be made where the endpoint is taken from the first defined value in this list:
But this means that a defined HEX_CDN blanket overrides all repos, so using it to redirect to a hex.pm mirror breaks access to your own locally deployed artifactory—bringing us back to the original problem this PR was meant to fix. |
This was referenced Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Packages in hex repos defined in rebar.config cannot be fetched as their URL is always overriden.
Environment: detected in Erlang 23.0.3 + rebar 3.14.1, but most surely happening in other versions too (see further below for diagnosis)
How to reproduce:
bazpackage.rebar3 new lib foo)rebar3 depsExpectation:
bazis fetched correctly.Result:
bazis not downloaded, asrepo.hex.pmis accessed instead of the private repo.Reason found: though the
/packagesURL for the repo is queried correctly, when the associated/tarballsURL is built, any value in$HEX_CDNor (if empty)"repo.hex.pm"is used instead of the expectedrepo_urlprovided in config. This bug seems to have been introduced in #2204.Fix proposed:
$HEX_CDNor the default"repo.hex.pm"are only used if arepo_urlis not provided.